Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
added docs for the core team#3777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedApr 8, 2014
Has to be added to |
contributing/code/core_team.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
remove the comma before the and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it's our standard to not use the serial oxford comma :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that's a shame :(
xabbuh commentedApr 8, 2014
What do you think about linking the names of the members to their GitHub profiles? |
bobdenotter commentedApr 8, 2014
Ah, a proposed solution for the "But what if Fabian gets hit by a bus?" problem. :-) But seriously, this is a good thing IMHO. |
vicb commentedApr 8, 2014
@fabpot best late than never! There is one thing that I would suggest, create an "currently inactive"category for inactive members. People do (also) contribute to get credits and giving them would be fair. Symfony would not be what it is now without the work of all its contributors. Win-win. Note: I'm not asking to be part of this cat. The "core team" never existed before and I have been inactive for way too long... |
fabpot commentedApr 8, 2014
@vicb: That's something totally different and that's already addressed, seehttp://symfony.com/contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Merges pull requests [...] to be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, there isone project leaders butmany mergers.
vicb commentedApr 8, 2014
Having the contributor page is nice. Not sure it's "totally different" though... But you decide, you're the project leader ;) On April 8, 2014 5:01:11 AM PDT, Fabien Potenciernotifications@github.com wrote:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
-1 for this, it's open source. The opinion of other, non core, contributors should also be considered when accepting/rejecting a PR imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you think about it, the new workflow greatly improves the current situation. In the past, when the discussion about a pull request reached and endpoint, it was only Fabien who decided what to do about that pull request.
With this new workflow, a lot of different people can decide what to do. And most of the Symfony Core members aren't SensioLabs employees, so I think that Fabien is acknowledging the importance of the community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can see that this policy reduces the power of Fabian :)
But it should be reworded a bit. In the current state, it implies that only the opinions of core members counts. That can give "normal" contributors a feeling that their opinion isn't important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Discussions are more than encouraged, and they certainly influence votes from the deciders. But at the end of the day, and this has nothing to do with being Open-Source or not, someone has to decide whether a feature should be included or not; and that's the role of the core team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 i see this as a great advancement in the community, i mean this document. Thank you for taking the time to do this really.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@wouterj the assumption is of course that just as before, the opinions of the community are taking into advisement with all decisions. Now it can of course be noted as a fact in the process but imho that complicates the definition of the actual process for a "political" gain. Not saying that politics isn't important and politics is a natural part of anything that involves more than a few people (for example the process could be used by some people to bad mouth Symfony saying "look they do not care about their community opinions). But in the grand scheme of things what will matter the most is the actions in practice.
javiereguiluz commentedApr 8, 2014
@vicb I think that I understand your petition. You believe that we need to add a new section called"Past Core Members". You are right. We haven't added it in this document because there are no past members yet (the old symfony 1.x core members don't apply for this and the special developers that contributed a lot during the past years, as is your case, don't apply either because there was no formalsymfony core group). |
GrahamCampbell commentedApr 9, 2014
I noticed this is targeted at the master branch. Would it not make sense to target this at 2.3, that is, if I have understood this right, and this change means the core team can push changes to the 2.3 branch too? |
stof commentedApr 9, 2014
@GrahamCampbell the right target would indeed be 2.3. But anyway, this can be changed at merge time by@weaverryan |
GrahamCampbell commentedApr 9, 2014
Sure. |
weaverryan commentedMay 2, 2014
Hi everyone! I've let this sit for a bit, but there's no active conversation and, as far as I can tell, no additional changes that weneed to make. Obviously, this is a process that will likely evolve, and that's good. So, I've merged this, and we can "evolve" via future iterations. If anyone has any large concerns, please make them known on a new issue or PR. Thanks! |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#3777).Discussion----------added docs for the core team| Q | A| ------------- | ---| Doc fix? | no| New docs? | n/a| Applies to | all| Fixed tickets | n/aThe Symfony Core Team is back!Commits-------d734600 added docs for the core team
The Symfony Core Team is back!