Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[book] Misc. routing fixes#3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
javiereguiluz commentedMar 29, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | - |
instead of the British bi-directional
Previously, the code used the generate() method of the service andthe note explained the generateUrl() method of the base controller.Then, the example was updated to use the generateUrl(), but thenote kept explaining the generateUrl(). This change is just aboutexplaining in the note the alterantive generate() method of the service.
| @@ -1168,12 +1168,15 @@ route. With this information, any URL can easily be generated:: | |||
| .. note:: | |||
| In controllers that extend Symfony's base | |||
| In controllers thatdon'textend Symfony's base | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How do you call theget() method of FrameBundle'sController if your controller doesn't extend it?
@xabbuh thanks for your review! I've fixed the sample code and reworded the paragraph. |
weaverryan added a commit that referenced this pull requestApr 2, 2014
This PR was merged into the 2.3 branch.Discussion----------[book] Misc. routing fixes| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets | -Commits-------7500435 [book] [routing] minor rewording and fixed some sample code26f9e3b [book] [routing] fixed a note that wasn't properly updated355cd5b [book] [routing] reworded the note about generating URLs in consoleda8b46f [book] [routing] used the American term "bidirectional" instead of the British bi-directional
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.