Fix issue #3712#3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

umpirsky wants to merge3 commits intosymfony:masterfromumpirsky:patch-1

Closed

Fix issue #3712#3716

umpirsky wants to merge3 commits intosymfony:masterfromumpirsky:patch-1

Conversation

Copy link

Contributor

umpirsky commentedMar 24, 2014

No description provided.

cordoval reviewed

Mar 24, 2014

View reviewed changes

book/installation.rst Outdated

Copy link

Contributor

cordovalMar 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this more of a revert? maybe try to add a note in cases when we want -dRn and in the other majority of cases when we just want the stuff working 👶

Copy link

Contributor

cordoval commentedMar 24, 2014

👍

Copy link

Member

weaverryan commentedMar 26, 2014

@umpirsky What do you think about a quick sentence after the code block?

If this doesn't work, try adding a-n flag to each command

Then we can merge, even without totally understanding what is right :)

weaverryan mentioned this pull request

Mar 26, 2014

setfacl potentially not working anymore#3712

Closed

Copy link

ContributorAuthor

umpirsky commentedMar 26, 2014

@weaverryan Hehum, I don't like writing about things I don't understand, but done. :)

Copy link

Member

weaverryan commentedMar 27, 2014

Thanks@umpirsky :). Actually, what do you think about just having a note about adding-n without the second code block? This section is already long, I want to be clear, but keep things somewhat short.

Can can you rebase against the 2.3 branch - e.g.git rebase master --onto 2.3? That'll help me patch this cleanly onto the 2.3 branch (no need to actually open a new PR against 2.3).

Cheers!