Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Add support for nginx#3706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This doesn't work for nginx you forgot the user. It's a broadly used webserver at this point and should be included.
I think it should absolutely be included - thanks@guiditoito! Now, of course it doesn't really matter, but we should probably also change APACHEUSER to something else (like WEBUSER) |
weaverryan added a commit that referenced this pull requestMar 24, 2014
This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes#3706).Discussion----------Add support for nginxThis doesn't work for nginx you forgot the user. It's a broadly used webserver at this point and should be included.Commits-------3d652f3 Add support for nginx
weaverryan added a commit that referenced this pull requestMar 26, 2014
This PR was merged into the 2.3 branch.Discussion----------change variable name to a better fitting one| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |As mentioned by@weaverryan in#3706 since Nginx is supported the name ``$APACHEUSER`` doesn't any more match its usage really properly. Thus, I renamed it to ``$HTTPDUSER``.Commits-------2f99c90 change variable name to a better fitting one
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't work for nginx you forgot the user. It's a broadly used webserver at this point and should be included.