Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Dynamic form modification cookbook: Fix inclusion of code#3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Includes in a code block don't work, replace them with the actual code
Hmm, very unfortunate indeed, but nice catch and thanks for looking into this further Michaël. I guess we'll have to be ok with this little bit of duplication - we have a lot of people keeping an eye out for not forgetting to change everything needed :). Thanks! |
… (michaelperrin)This PR was merged into the 2.3 branch.Discussion----------Dynamic form modification cookbook: Fix inclusion of codeUnfortunately, reStructuredText doesn't support inclusion of code inside a code block, resulting to non-interpreted code (the `include` keyword is not displayed) as it happens onhttp://symfony.com/doc/2.3/cookbook/form/dynamic_form_modification.html .I tried in many ways to avoid this, but didn't find any nice way. I had to duplicate code instead.The PR includes a few minor fixes on code style as well.Commits-------1e8b0d4 Small fixes in code style8093719 Dynamic form modification cookbook: Fix inclusion of code
Yes indeed, I didn't like to have to duplicate code. That will be alright thanks to the active community! |
This PR was merged into the 2.3 branch.Discussion----------Fix PSR coding standards error| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3| Fixed tickets |Commits-------da2ee60 Fix PSR coding standards error868de1e minor#3698 Dynamic form modification cookbook: Fix inclusion of code (michaelperrin)acf255d feature#3328 [WIP] Travis integration (WouterJ)5d99d88 [#3697] Backporting 2.3-specific changes1e8b0d4 Small fixes in code style8093719 Dynamic form modification cookbook: Fix inclusion of code37eb137 Update documentation8dec729 sparse checkoutsb6f693e Added CMFb1d9e62 Revert changes6cad008 Updated travis configc515613 Added .gitignore85b1b02 Try to supress bundle doc warningsf3cb8b1 Fixed submodules71a2ff4 Added needed config filesd312683 Added sphinx files
Unfortunately, reStructuredText doesn't support inclusion of code inside a code block, resulting to non-interpreted code (the
includekeyword is not displayed) as it happens onhttp://symfony.com/doc/2.3/cookbook/form/dynamic_form_modification.html .I tried in many ways to avoid this, but didn't find any nice way. I had to duplicate code instead.
The PR includes a few minor fixes on code style as well.