Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cookbook][Test] fix sample code#3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.3frominelgnu:2.3
Mar 12, 2014
Merged

Conversation

inelgnu
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies toall

@inelgnuinelgnu deleted the 2.3 branchMarch 12, 2014 09:41
@inelgnuinelgnu restored the 2.3 branchMarch 12, 2014 09:41
@inelgnuinelgnu reopened thisMar 12, 2014
@wouterj
Copy link
Member

Thank you for your work. 2 tips from me (for the next time):

  • We can easily cherry pick commits into other branches, you don't need to create a new PR for that.@bicpi just told it you, so you do it right the next time :)
  • Always create a new branch when editing something (when editing a file from this repo of a specific branch, you'll always create a patch-N branch in your own fork). When doing this, you can create multiple PRs at the same time.

@weaverryan
Copy link
Member

Great fix - thanks @inalgnu!

weaverryan added a commit that referenced this pull requestMar 12, 2014
This PR was merged into the 2.3 branch.Discussion----------[Cookbook][Test] fix sample code| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | allCommits-------370d614 [Cookbook][Test]fix sample code
@weaverryanweaverryan merged commit370d614 intosymfony:2.3Mar 12, 2014
@inelgnuinelgnu deleted the 2.3 branchMarch 12, 2014 20:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@inelgnu@wouterj@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp