Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Reference][Forms] remove the label_attr option which is not available in the button type#3651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👍 makes perfect sense! |
…not available in the button type (xabbuh)This PR was merged into the 2.3 branch.Discussion----------[Reference][Forms] remove the label_attr option which is not available in the button type| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |The ``label_attr`` is neither defined in the ``ButtonType`` class nor in the ``BaseType`` class, but in the ``FormType`` class instead. Thus, it can't be used for the ``button`` type.Commits-------5bafc3c remove the label_attr option which is not available in the button type
happypoulp commentedJun 27, 2014
The label_attr is still appearing in the documentation for the button type: http://symfony.com/fr/doc/current/reference/forms/types/button.html |
@happypoulp You are looking at the French translation which has its own repository. Seems not to be up-to-date. |
@happypoulp you should report it tohttps://github.com/symfony-fr/symfony-docs-fr/ And I think the french translator will be even happier if you submit a PR to that repo, removing the same things as@xabbuh did here. |
happypoulp commentedJun 28, 2014
Good to know, I'll do that, thanks! |
The
label_attris neither defined in theButtonTypeclass nor in theBaseTypeclass, but in theFormTypeclass instead. Thus, it can't be used for thebuttontype.