Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix Image constraint class and validator link#3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jbafford wants to merge1 commit intosymfony:2.1fromjbafford:patch-1

Conversation

jbafford
Copy link
Contributor

Change Image constraint links from File and FileValidator to Image and ImageValidator.

Change Image constraint links from File and FileValidator to Image and ImageValidator.
@xabbuh
Copy link
Member

👍

@weaverryan
Copy link
Member

This looks good, but@jbafford can you open a new PR against 2.3? That's the earliest supported branch, and it looks like trying to patch this into 2.3 cause a conflict.

Thanks!

@jbafford
Copy link
ContributorAuthor

I think the difference is minor formatting changes, but sure, I'll open a new PR against a newer version later today.

@weaverryan
Copy link
Member

Yea, I'm sure it is - but I use a utility to merge in that also tracks a lot of extra metadata about the PR, but it doesn't (yet) have the super-power to switch branches and fix conflicts. So, I appreciate it in advance :)

@weaverryan
Copy link
Member

Ping@jbafford! No rush, just bothering you :)

weaverryan added a commit that referenced this pull requestApr 2, 2014
This PR was merged into the 2.3 branch.Discussion----------Fix Image constraint class and validator linkJust a rebase of#3646...Commits-------2a3955b Fix Image constraint class and validator link
@weaverryan
Copy link
Member

Rebased and merged over at#3747. Thanks John (and no worries about not rebasing)!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@jbafford@xabbuh@weaverryan
[8]ページ先頭
©2009-2025 Movatter.jp