Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Fixed some typos and formatting issues#3642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedMar 6, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | no |
| your application could operate without clashing. For example, `module1.foo` and | ||
| `module2.foo`. However, sometimes this is not very practical when the attributes | ||
| your application could operate without clashing. For example, ``module1.foo`` and | ||
| ``module2.foo``. However, sometimes this is not very practical when the attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
remove very? it is not practical ismore fit -> fit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@cordoval I don't understand your proposal. This is the original phrase:
However, sometimes this is not very practical when the attributes [...]What would you replace it for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
just commenting that sometimes the word already has the meaning, so usually we sayvery practical whenpractical is enough as an adjective. It is a nuance when there is nothing to compare it with. That is why I added my inline examplemore fit when what i meant was just fit. Maybe it is ok, just raising up a point of discussion. Sorry maybe it is just me. 👶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like the current way
Awesome again - thanks Javier! Btw, if things apply to 2.3, you can create a PR against the 2.3 branch. I'm patching these into 2.3 anyways, but if the PR is against 2.3, it'll prevent any expected conflicts when I merge to a differnt branch :). Cheers! |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#3642).Discussion----------Fixed some typos and formatting issues| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets | noCommits-------ce6fc73 Minor corrections9a3b12f Fixed some typos and formatting issues
any *unexpected conflicts 😉 |