Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update security.rst#3636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update security.rst#3636
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I'm not a native speaker but I think that it sounds better by adding that before the word `start`.
book/security.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Our standard is to avoid the first person perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree with both of you, we should avoid the first person, but the current sentence really needs a first person perspective here. So we have to rewrite the complete sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ha, I'm also struggling a bit here :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since the best way to learn is to see an example, just imagine that you want to secure your application with HTTP Basic authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yea, that's really great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@weaverryan I'll close this PR because I did it with the edit featured of GitHub and I'll create a new one with this change by@xabbuh
alvarezmario commentedMar 27, 2014
Well, I think that's not necessary so I'll do it in this one in a moment. |
alvarezmario commentedMar 27, 2014
@weaverryan It's done. |
weaverryan commentedMar 31, 2014
Great, thanks Mario! |
I'm not a native speaker but I think that it reads better now.