Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Reference][Forms] add an introductory table containing all options of the basic form type#3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedFeb 26, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| @@ -4,11 +4,44 @@ | |||
| form Field Type | |||
| =============== | |||
| See :class:`Symfony\\Component\\Form\\Extension\\Core\\Type\\FormType`. | |||
| The ``form`` type predefines a couple of options that are then available | |||
| on all fields. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
all fields that have form as parent. They can also specify another form type as parent, or no parent at all.
We may need to seperate it a bit more: As of 2.3, the form type is extracted in a So we can't say, these options are available on every field. And we may need to make a difference between options of the |
You're right. This also applies to the |
No, I think we should split the Form Type article. Or add something like |
We can go that way. But then the same should be documented for the |
I added an additional table to the |
| The following options are defined in the | ||
| :class:`Symfony\\Component\\Form\\Extension\\Core\\Type\\BaseType` class. | ||
| The ``BaseType`` class is the parent class for both the ``button`` type and | ||
| the :doc:`form type </reference/forms/types/form>` but it is not part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I prefer a comma before "but"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right. That really does make sense.
I also added docs for the |
| :class:`Symfony\\Component\\Form\\Extension\\Core\\Type\\BaseType` class. | ||
| The ``BaseType`` class is the parent class for both the ``button`` type and | ||
| the :doc:`form type </reference/forms/types/form>`, but it is not part of | ||
| the form type tree (i.e. it can not be used as a form type on its own). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure if I want this level of detail here - I don't think it matters very much what the parent type is when it's "form", and I especially don't think it's very important to say exactly which class you can find the code in. Thoughts?
@xabbuh I think I'm happy with this now :). Can you rebase for me? |
… type reference docs
@weaverryan Of course, here you are. |
Awesome, thank you very much! |
…ll options of the basic form type (xabbuh)This PR was merged into the 2.3 branch.Discussion----------[Reference][Forms] add an introductory table containing all options of the basic form type| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |Commits-------b3ca94c removed the description of the auto_initialize option from the button type reference docs58170fe document the auto_initialize option for the form type, refs#34102ca0306 document the options inherited from the BaseType class911cc70 add an introductory table containing all options of the basic form type