Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Document how to create a custom type guesser#3597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj commentedFeb 22, 2014
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | #481 |
| * :method:`Symfony\\Component\\Form\\FormTypeGuesserInterface::guessMaxLength` - | ||
| tries to guess the value of the ``max_length`` option; | ||
| * :method:`Symfony\\Component\\Form\\FormTypeGuesserInterface::guessPattern` - | ||
| tries to guess the value of the ``pattern`` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we could link the option to their descriptions in the reference docs
👍 Great work! But I am wondering if this article should be moved to the cookbook. |
It's independent of the framework and very usefull if you are using the form component standalone. |
Actually, this also applies to a lot of cookbook articles, doesn't it? |
Only a few are fully framework independant and I really want to move them to the components section |
| --------------------- | ||
| In this section, you are going to build a PHPDoc type guesser. At first, you | ||
| need to create a class which extends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wich implements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1
AND, how about we change the header to "Create a PHPDoc Type Guesser" and then remove the first sentence (or replace it with something describing what this means - e.g. "In this section, you are going to build a guesser that reads information about fields from the PHPDoc above the properties").
Thank you,@weaverryan@xabbuh@ggam. I've fixed all of your comments. |
Awesome! So many new pieces coming into the docs lately - thanks! |
@weaverryan yeah, I decided it was time to clear up the milestones. My goal is to have all milestoned issues at least tagged with "has pr" when 2.5 is released. |