Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[HTTP Cache] Validation model: Fix header name#3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
For the expiration model, there's a note below the code, I may add a similiar one for the validation model? The If-Modified-Since request header equals the Last-Modified header of the last response sent to the client for the particular resource. This is how the client and server communicate with each other and decide whether or not the resource has been updated since it was cached. |
I've added the above mentioned tip for the validation model, i.e. the equivalent tip that is used for the expiration modelin the next section. |
Yes, obviously much more accurate now - thanks! |
This PR was merged into the 2.3 branch.Discussion----------[HTTP Cache] Validation model: Fix header name| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | -In the cache validation model, the response sends an `ETag` header, but the following requests send an `If-None-Match` header. So the `If-None-Match` header from the request is compared to the `ETag` from the previous response. See `Symfony\Component\HttpFoundation\Request::getETags()` which is used by `Symfony\Component\HttpFoundation\Response::isNotModified()`.Commits-------f7ef7c0 [HTTP Cache] Validation model: Fix header name
I realized that the sentence on the notes was a bid hard to read. I also removed a usage ofthe word "client" right before this, so I can use the word "cache" instead (meaning, I wantthe user to be thinking about the reverse proxy, not a user's browser cache - that's valid,but not the typical use-case).
This PR was merged into the 2.3 branch.Discussion----------Http cache validation rewordingHiya guys!This comes after#3596.I realized that the sentence on the notes was a bid hard to read. I also removed a usage ofthe word "client" right before this, so I can use the word "cache" instead (meaning, I wantthe user to be thinking about the reverse proxy, not a user's browser cache - that's valid,but not the typical use-case).| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | -Thanks!Commits-------a7cdfe9 [#3596] Tweaking language on HTTP cache
In the cache validation model, the response sends an
ETagheader, but the following requests send anIf-None-Matchheader. So theIf-None-Matchheader from the request is compared to theETagfrom the previous response. SeeSymfony\Component\HttpFoundation\Request::getETags()which is used bySymfony\Component\HttpFoundation\Response::isNotModified().