Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Collection of fixes and improvements#3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bicpi commentedFeb 21, 2014
If I've mixed too much topics I may split this PR. |
book/security.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would prefer to instead fix the code example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I also thought about this option which would mean to change theaccess_control rule to^/admin/.
But maybe users are not aware that securing with^/admin/ excludes a possible admin area entry point/admin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good point! Let's keep it like this.
I don't like/admin* btw, can't we change it to show that only once and say "starts with/admin" in other occurences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I totally agree that/admin* looks ugly.
What about adding a 2nd access rule in the code for^/admin$ with a code comment that this is necessary to also secure the/admin path itself? I think this is used somewhere else to secure^/login$.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1
xabbuh commentedMar 7, 2014
👍 |
weaverryan commentedMar 7, 2014
WOW, I can't believe how many tweaks you found - that's incredible! Thanks aton for this. Also, I like what you guys decided on for the access control part - very clear. Cheers! |
This PR was merged into the 2.3 branch.Discussion----------Collection of fixes and improvements| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | -This PR fixes all kind of typos, formatting and code issues.It also adds some missing code blocks and notes or improvements.Thanks for your review and please let me know if you see something wrong.Commits-------56e475c Fixes after review8d4f444 Fixes of all kind
This PR fixes all kind of typos, formatting and code issues.
It also adds some missing code blocks and notes or improvements.
Thanks for your review and please let me know if you see something wrong.