Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Fix build errors#3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Fix build errors#3578
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This PR was merged into the 2.3 branch.Discussion----------fix form type name.| Q | A| ------------- | ---| Doc fix? | [yes]| New docs? | [no]| Applies to | [all]| Fixed tickets |Commits-------ef4014d fix form type.
Line 41 made use of $crawler which wasn't defined.
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closessymfony#3537).Discussion----------Add missing variable assignmentLine 41 made use of $crawler which wasn't defined.Commits-------8f41c15 Add missing variable assignment
This PR was merged into the 2.3 branch.Discussion----------Clarify service parameters usages| Q | A| --- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | IRCOn the IRC channel, there was some confusing about parameters. The dotnotation looked like parameters are one big namespaced tree, with eachgroup a different node.This PR adds a caution, so people really know it's just a convention andparameters are just key-value elements.Commits-------aaddfcd Applied comment05492b2 Clarify parameters conventions
The $event['data'] field was not set, thus it wouldn't be modified.Also, the example already had a lowercase string. Uppercased 1 letter.
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closessymfony#3541).Discussion----------Update generic_event.rstThe $event['data'] field was not set, thus it wouldn't be modified.Also, the example already had a lowercase string. Uppercased 1 letter.Commits-------029f4e1 Update generic_event.rst
… in the overriden options section
Wrong base branch. See#3579. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of#3544.