Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Development of custom error pages is impractical if you need to set kernel.debug=false#3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mpdude wants to merge4 commits intosymfony:masterfromwebfactory:add-note-exceptions-bundle
Closed

Development of custom error pages is impractical if you need to set kernel.debug=false#3577

mpdude wants to merge4 commits intosymfony:masterfromwebfactory:add-note-exceptions-bundle

Conversation

@mpdude
Copy link
Contributor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

During Development

@wouterj
Copy link
Member

+1, I like having references to 3rd party bundles to help with common tasks.

However, I'd like to have this in a.. sidebar:: instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[...] impractical as, among other things, it stops Symfony2 from recompiling the Twig templates.

@wouterj
Copy link
Member

Maybe it's better if we make the section a bit shorter. Among the lines of:

In the development environment, theExceptionController of the TwigBundle is used instead of error pages. When testing your code in the production environment, the twig templates cache won't be updated, this means it's hard to test your custom error pages. Luckily, thewebfactory/exceptions-bundle_ solves this issue by providing a test controller.

Move section on testing error pages during development into a sidebar and make it shorter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you should putkernel.debug on one line

@mpdude
Copy link
ContributorAuthor

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would use WebfactoryExceptionsBundle.

@mpdude
Copy link
ContributorAuthor

@xabbuh You're right, the bundle name is better than the composer vendor/package combo.

@mpdude
Copy link
ContributorAuthor

bump

@weaverryan
Copy link
Member

Hey Matthias! Thanks for the bundle and this change - this is a very annoying thing indeed. Maybe someday it'll be in core, but until then, as Wouter mentioned, we should link to the best tool for the job. I haven't tried your bundle yet, so hopefully it's good ;). I think you should register it on KnpBundles.com too so it's a bit easier to find. And you will now be able to update your blog post where it references that we don't talk about this problem yet on the docs ;). Anyways, thanks a bunch!

weaverryan added a commit that referenced this pull requestMar 9, 2014
… need to set kernel.debug=false (mpdude)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#3577).Discussion----------Development of custom error pages is impractical if you need to set kernel.debug=falseAlso seesymfony/symfony#7446 andsymfony/symfony#1486Commits-------6aa90e0 Use WebfactoryExceptionsBundle instead of webfactory/exceptions-bundle2fee263 Update error_pages.rst435019c Point out the difference between error and exception pages.2194607 Add a pointer to webfactory/exceptions-bundle which helps with development of custom error pages.
@mpdudempdude deleted the add-note-exceptions-bundle branchMarch 10, 2014 23:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mpdude@wouterj@weaverryan@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp