Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Development of custom error pages is impractical if you need to set kernel.debug=false#3577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…pment of custom error pages.
cookbook/controller/error_pages.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
During Development
wouterj commentedFeb 13, 2014
+1, I like having references to 3rd party bundles to help with common tasks. However, I'd like to have this in a |
cookbook/controller/error_pages.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[...] impractical as, among other things, it stops Symfony2 from recompiling the Twig templates.
wouterj commentedFeb 13, 2014
Maybe it's better if we make the section a bit shorter. Among the lines of: In the development environment, the |
Move section on testing error pages during development into a sidebar and make it shorter.
cookbook/controller/error_pages.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you should putkernel.debug on one line
mpdude commentedFeb 13, 2014
Fixed |
cookbook/controller/error_pages.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would use WebfactoryExceptionsBundle.
mpdude commentedFeb 17, 2014
@xabbuh You're right, the bundle name is better than the composer vendor/package combo. |
mpdude commentedMar 8, 2014
bump |
weaverryan commentedMar 9, 2014
Hey Matthias! Thanks for the bundle and this change - this is a very annoying thing indeed. Maybe someday it'll be in core, but until then, as Wouter mentioned, we should link to the best tool for the job. I haven't tried your bundle yet, so hopefully it's good ;). I think you should register it on KnpBundles.com too so it's a bit easier to find. And you will now be able to update your blog post where it references that we don't talk about this problem yet on the docs ;). Anyways, thanks a bunch! |
… need to set kernel.debug=false (mpdude)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#3577).Discussion----------Development of custom error pages is impractical if you need to set kernel.debug=falseAlso seesymfony/symfony#7446 andsymfony/symfony#1486Commits-------6aa90e0 Use WebfactoryExceptionsBundle instead of webfactory/exceptions-bundle2fee263 Update error_pages.rst435019c Point out the difference between error and exception pages.2194607 Add a pointer to webfactory/exceptions-bundle which helps with development of custom error pages.
Also see
symfony/symfony#7446 andsymfony/symfony#1486