Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Add missing variable assignment#3537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Line 41 made use of $crawler which wasn't defined.
Thank you for submitting the fix! It should be merged into 2.3 (2.0, 2.1 and 2.2 are deprecated and no longer maintained). You don't have to create your PR again,@weaverryan (who will merge your PR) can cherry pick it quite easily in the correct branch. |
Yes, very good mistake fix :). Thanks Colin! |
@weaverryan, will this be merged into the 2.4 branch as well? |
@colinodell Yes it will! We merge 2.3 into 2.4 into master. It doesn't happen after every merge - but happens about once a week :). |
…er (colinodell)This PR was merged into the 2.3 branch.Discussion----------Fix README: contributions should be based off 2.3 or higherPer [the documentation](http://symfony.com/doc/current/contributing/documentation/overview.html#contributing) and [WouterJ's comment here](#3537 (comment)), the base branch should be 2.3, not 2.2. This commit updates the README to reflect the language found in the documentation.| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets | n/aCommits-------ed5eab7 Contributions should be based off 2.3 or higher
Line 41 made use of $crawler which wasn't defined.