Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Book][Security] remove duplicate label#3524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I wonder why things slip in that way, maybe because of the order of commits or lack of rebase, lack of ripple merging of PRs to older bases? or merges across branches? |
Yeah, as you can see in the commit mentioned in the PR description, there have been conflicts. Thus, I guess this slipped through when the conflicts were resolved. For things like this which fix build errors, having the Travis integration running would ease Ryan's work. |
yes i agree. I was wondering if there could be a messup detector as well, like identifying the duplicate lines for instance. he I am always now thinking where can Gush commands help. |
The line is gone now in @xabbuh but yes, I'm excited for the Travis integration - I'm going to find time soon to get that merged in - it will be really great! |
This has been previously fixed in#3456 but somehow slipped through in8bd668e.