Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Type fix in remove.rst#3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit into2.3fromremove-typo
Feb 11, 2014
Merged

Type fix in remove.rst#3493

weaverryan merged 1 commit into2.3fromremove-typo
Feb 11, 2014

Conversation

@weaverryan
Copy link
Member

Hi guys!

Very minor typo fix... leaving the PR format off.

Thanks!

@wouterj
Copy link
Member

Ironically, your PR title also need a typo fox .. fix 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

notan acme_demo string?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

btw. do you think it's better to useacme_demo here instead of the more generic tip?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we changed it to the current way just a week ago, not sure if this was intended by@weaverryan

@weaverryan
Copy link
MemberAuthor

@xabbuh you're right withan acme_demo string - I've fixed that, thanks :). But I don't understand your other comment:

do you think it's better to use acme_demo here instead of the more generic tip?

The last change before this PR was sha:a4d804d

Thanks!

@xabbuh
Copy link
Member

do you think it's better to use acme_demo here instead of the more generic tip?

The last change before this PR was sha:a4d804d

Yes, I see. But you revert@cordoval's change and I was wondering if that was intended.

weaverryan added a commit that referenced this pull requestFeb 11, 2014
This PR was merged into the 2.3 branch.Discussion----------Type fix in remove.rstHi guys!Very minor typo fix... leaving the PR format off.Thanks!Commits-------efaad48 Fixing typo - thanks to@xabbuh
@weaverryanweaverryan merged commitefaad48 into2.3Feb 11, 2014
@weaverryanweaverryan deleted the remove-typo branchFebruary 11, 2014 00:36
@weaverryan
Copy link
MemberAuthor

Ah, of course@xabbuh - I don't know how I did that :). Fixed back now, with just that little typo fix.

Thanks!

@xabbuh
Copy link
Member

Great! :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weaverryan@wouterj@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp