Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cookbook][Assetic] Fix "javascripts" tag name typo#3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 2 commits intosymfony:2.3frombicpi:fix_assetic_tag_name
Feb 1, 2014
Merged

[Cookbook][Assetic] Fix "javascripts" tag name typo#3485

weaverryan merged 2 commits intosymfony:2.3frombicpi:fix_assetic_tag_name
Feb 1, 2014

Conversation

bicpi
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets-

Maybe the following noteThis will most commonly live in thejavascripts block... is a bit confusing because the example does not show this Twig block and it has the same name as the Twig tag... The note could either be removed or I could add thejavascripts Twig block to clarify?

@wouterj
Copy link
Member

+1 to move the note to a note directive after the example, showing the javascritps block.

@bicpi
Copy link
ContributorAuthor

@wouterj I've moved it to a note and likewise forstylesheets. Also changed "Standard Distribution" to "Standard Edition".

@wouterj
Copy link
Member

@bicpi you should also add the PHP format. (see the templating component docs for a PHP example of blocks)

And -1 for Standard Distribution to Standard Edition, it's the Standard Distribution of Symfony, which is called the Standard Edition.

@bicpi
Copy link
ContributorAuthor

@wouterj I'm a bit confused about the Distribution/Edition thing now. I thought the only official Symfony Distribution is the Standard Edition (on the Download page) and the note talks about the Twig blocks in this Standard Edition. I wanted to include the PHP example, but the Standard Edition does not provide a base PHP template - in this case it would not make sense to add PHP samples.

@weaverryan
Copy link
Member

I really like the change - tI've seen the javascripts block versus tag confuse many people - I think you handled it very nicely. And I agree - since there is no PHP base template, Ithe note with just Twig makes sense to me :). Cheers!

weaverryan added a commit that referenced this pull requestFeb 1, 2014
This PR was merged into the 2.3 branch.Discussion----------[Cookbook][Assetic] Fix "javascripts" tag name typo| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets | -Maybe the following note *This will most commonly live in the ``javascripts`` block...* is a bit confusing because the example does not show this Twig block and it has the same name as the Twig tag... The note could either be removed or I could add the `javascripts` Twig block to clarify?Commits-------f9a287b Move note about "javascripts" and "stylesheets" blocks to separate note blockscf8064d [Cookbook][Assetic] Fix "javascripts" tag name typo
@weaverryanweaverryan merged commitf9a287b intosymfony:2.3Feb 1, 2014
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@bicpi@wouterj@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp