Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Cookbook][Assetic] Fix "javascripts" tag name typo#3485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
+1 to move the note to a note directive after the example, showing the javascritps block. |
@wouterj I've moved it to a note and likewise for |
@bicpi you should also add the PHP format. (see the templating component docs for a PHP example of blocks) And -1 for Standard Distribution to Standard Edition, it's the Standard Distribution of Symfony, which is called the Standard Edition. |
@wouterj I'm a bit confused about the Distribution/Edition thing now. I thought the only official Symfony Distribution is the Standard Edition (on the Download page) and the note talks about the Twig blocks in this Standard Edition. I wanted to include the PHP example, but the Standard Edition does not provide a base PHP template - in this case it would not make sense to add PHP samples. |
I really like the change - tI've seen the javascripts block versus tag confuse many people - I think you handled it very nicely. And I agree - since there is no PHP base template, Ithe note with just Twig makes sense to me :). Cheers! |
This PR was merged into the 2.3 branch.Discussion----------[Cookbook][Assetic] Fix "javascripts" tag name typo| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | -Maybe the following note *This will most commonly live in the ``javascripts`` block...* is a bit confusing because the example does not show this Twig block and it has the same name as the Twig tag... The note could either be removed or I could add the `javascripts` Twig block to clarify?Commits-------f9a287b Move note about "javascripts" and "stylesheets" blocks to separate note blockscf8064d [Cookbook][Assetic] Fix "javascripts" tag name typo
Maybe the following noteThis will most commonly live in the
javascripts
block... is a bit confusing because the example does not show this Twig block and it has the same name as the Twig tag... The note could either be removed or I could add thejavascripts
Twig block to clarify?