Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[WIP][Reference][Form Types] Update "radio" form type#3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -27,7 +27,7 @@ If you want to have a Boolean field, use :doc:`checkbox </reference/forms/types/ | |||
| | | - `error_mapping`_ | | |||
| | | - `mapped`_ | | |||
| +-------------+---------------------------------------------------------------------+ | |||
| | Parent type | :doc:`form </reference/forms/types/form>` | | |||
| | Parent type | :doc:`form </reference/forms/types/checkbox>` | | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
form should also be changed to checkbox
You're correct about the value type. In the Inherited Options sections, add a new thing at first which starts with: " These options inherit from the :doc: |
@wouterj The |
👍 |
Can you rebase this? |
@xabbuh Ups, that was a rebase on master by mistake. Mh, good question how to roll this back... |
@xabbuh Now the rebase should be okay. |
👍 great@bicpi, this should make life easier for@weaverryan since#3416 was merged in the meantime |
yes, it's succesfully rebased! |
Great work Philipp! This is very subtle, tough to get perfectly. Thanks for your attention on it. |
This PR was merged into the 2.3 branch.Discussion----------[WIP][Reference][Form Types] Update "radio" form type| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets |#3410`radio`'s parent is `checkbox`, not `form`.I need some help regarding the task *value option should be removed from this type*:Should it really be removed? It's because I'm able to set it and it is used in the HTML output. I'm retrieving a boolean value only when I access the submitted data via the form framework but I have also access to the raw, custom value via e.g. `$request->request->get('my_checkbox')`. So maybe it should be moved to the `inherited options` instead for the `radio` field? If yes, the wording would need an update for the `value` option and if no, why keep it for the `checkbox` field?Commits-------322b21e Update&Outsource "value" option & update referencesbe47b90 Fix parent type doc reference22b3d0c [Reference][Form Types] Update "radio" form type
radio's parent ischeckbox, notform.I need some help regarding the taskvalue option should be removed from this type:
Should it really be removed? It's because I'm able to set it and it is used in the HTML output. I'm retrieving a boolean value only when I access the submitted data via the form framework but I have also access to the raw, custom value via e.g.
$request->request->get('my_checkbox'). So maybe it should be moved to theinherited optionsinstead for theradiofield? If yes, the wording would need an update for thevalueoption and if no, why keep it for thecheckboxfield?