Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Reference][Form Types] Add "max_length" option in form type#3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
nykopol commentedJan 6, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| Applies to | 2.3+ |
| Fixed tickets | #3410 (task Form -> max_length) |
👍 |
| If this option is not null, an attribute ``maxlength`` is added, which | ||
| is used by some browsers to limit the amount of text in a field. | ||
| This is just a browser validation, so datas still must be validated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
client-side -- .. so data must still be ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks@bicpi It's fixed.
| If this option is not null, an attribute ``maxlength`` is added, which | ||
| is used by some browsers to limit the amount of text in a field. | ||
| This is just a browser validation, so datas must still be validated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
data, not datas :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed the last one !?
Awesome work@nykopol. Keep it up - and thanks! |
…e (nykopol)This PR was merged into the 2.3 branch.Discussion----------[Reference][Form Types] Add "max_length" option in form type| Q | A| ------------- | ---| Doc fix? | yes| New docs? | yes| Applies to | 2.3+| Fixed tickets |#3410 (task Form -> max_length)Commits-------b53a227 fix last typo on max length optiond6800d3 fix typo in previous commit391fe30 fix typo in previous commit2156545 add max_length to form field type