Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[WIP] #3412 documenting overriden options#3417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nykopol commentedJan 3, 2014
Q | A |
---|---|
Doc fix? | no |
New docs? | yes |
Applies to | 2.3 |
Fixed tickets | #3412 |
@weaverryan yes it's my mistake i did not start in an other branch. When you say a 'rebase' you think a new PR ? |
Hey@nykopol! No problem :). You can actually rebase your git checkout overridden_optionsgit fetch upstreamgit rebase upstream/mastergit push origin overridden_options --force As soon as you push to the Cheers! |
…y-docs into overriden_optionsConflicts:reference/forms/types/options/checkbox_compound.rst.increference/forms/types/options/checkbox_empty_data.rst.inc
Thanks@weaverryan for you help. I don't had conflict on rebase but on push. I hope it's ok now. |
Sorry@nykopol it's still conflicting. |
Hey@nykopol! Yea, it's still conflicting unfortunately :). Did you fetch from the "symfony/symfony-docs" repository and rebase againstits master? Let me know! Thanks! |
Hi guys! I've rebased and re-opened this PR at#3506 for review. I'll close this :). Thanks! |
This PR was merged into the 2.3 branch.Discussion----------Nykopol overriden optionsSee#3417 - this is just a rebase to continue it :)| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | 2.3| Fixed tickets |#3412Thanks!Commits-------e574e97 Removing an extra line thanks to@xabbuh4f6cb9d Some additional tweaks and probably some merge conflict fixes362c8b4 document overriden options of choice field70feefd document overriden options of checkboxc62cd13 correct overriden option of button and add checkbox overriden optionab4aafe correct overriden option of button and add checkbox overriden option