Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] #3412 documenting overriden options#3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
nykopol wants to merge8 commits intosymfony:masterfromnykopol:overriden_options

Conversation

nykopol
Copy link
Contributor

QA
Doc fix?no
New docs?yes
Applies to2.3
Fixed tickets#3412

@weaverryan
Copy link
Member

@nykopol - this looks good. It'll need a rebase (it contains some duplicated changes from#3407) - but keep going! :)

@nykopol
Copy link
ContributorAuthor

@weaverryan yes it's my mistake i did not start in an other branch. When you say a 'rebase' you think a new PR ?

@weaverryan
Copy link
Member

Hey@nykopol!

No problem :). You can actually rebase youroverridden_options branch and then force push right back to it. Assumingupstream is the remote name forsymfony/symfony-docs andorigin is to your fork, something like:

git checkout overridden_optionsgit fetch upstreamgit rebase upstream/mastergit push origin overridden_options --force

As soon as you push to theoverridden_options branch on your fork, those commits will show up here. You'll need to fix some conflicts after runningrebase.

Cheers!

@nykopol
Copy link
ContributorAuthor

Thanks@weaverryan for you help. I don't had conflict on rebase but on push. I hope it's ok now.

@wouterj
Copy link
Member

Sorry@nykopol it's still conflicting.

@weaverryan
Copy link
Member

Hey@nykopol!

Yea, it's still conflicting unfortunately :). Did you fetch from the "symfony/symfony-docs" repository and rebase againstits master?

Let me know! Thanks!

@weaverryan
Copy link
Member

Hi guys!

I've rebased and re-opened this PR at#3506 for review. I'll close this :).

Thanks!

weaverryan added a commit that referenced this pull requestFeb 3, 2014
This PR was merged into the 2.3 branch.Discussion----------Nykopol overriden optionsSee#3417 - this is just a rebase to continue it :)| Q             | A| ------------- | ---| Doc fix?      | no| New docs?     | yes| Applies to    | 2.3| Fixed tickets |#3412Thanks!Commits-------e574e97 Removing an extra line thanks to@xabbuh4f6cb9d Some additional tweaks and probably some merge conflict fixes362c8b4 document overriden options of choice field70feefd document overriden options of checkboxc62cd13 correct overriden option of button and add checkbox overriden optionab4aafe correct overriden option of button and add checkbox overriden option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@nykopol@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp