Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cookbook][Bundles] improve explanation of code block for bundle removal#3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

cordoval
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.3+
Fixed tickets#3384
LicenseCC-ASA 3.0 Unported

Sent usingGush

@cordovalcordoval restored the 3384-improve-explanation-of-code-block-for-bundle-removal branchJanuary 3, 2014 15:47
@@ -96,8 +96,8 @@ rely on the bundle you are about to remove.
.. tip::

If one bundle relies on another, in most it means that it uses some services
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ah, we have a typo here as well (in most cases it means). Could you possibly add that to your PR (even though it wasn't your mistake)?

Thanks :)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sorry i did not see this, I am in Salt Lake City, Utah now so this escaped me else I would have fixed it, sorry@weaverryan

@weaverryan
Copy link
Member

Thanks Luis!

weaverryan added a commit that referenced this pull requestJan 20, 2014
… bundle removal (cordoval)This PR was merged into the 2.3 branch.Discussion----------[Cookbook][Bundles] improve explanation of code block for bundle removal| Q             | A                   || ---           | ---                 || Doc fix?      | yes                 || New docs?     | no                  || Applies to    | 2.3+                || Fixed tickets |#3384               || License       | CC-ASA 3.0 Unported | Sent using [manager-tools](https://github.com/cordoval/manager-tools)Commits-------a4d804d improve explanation of code block for bundle removal and fix typo
@weaverryanweaverryan merged commita4d804d intosymfony:2.3Jan 20, 2014
@cordoval
Copy link
ContributorAuthor

we gotta get you close PRs with Gush@weaverryan 👶 justgsh p:merge 3413 and the closing message also can begsh i:close 3384 -m"Thanks Luis!" will save you tons of time cheers!

https://github.com/cordoval/gush

@cordovalcordoval deleted the 3384-improve-explanation-of-code-block-for-bundle-removal branchJanuary 20, 2014 04:00
@wouterj
Copy link
Member

@cordoval sorry, we choosed to use gh for the docs :)

And please, please stop with advertising of your tool. It becomes annoying...

@cordoval
Copy link
ContributorAuthor

in that case cool, I did not know it first hand from@weaverryan, thanks for the info@wouterj
and let me remind you about freedom of speech, 👶

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@cordoval@weaverryan@wouterj
[8]ページ先頭
©2009-2025 Movatter.jp