Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Changed sha1 into bcrypt continued...#3405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… details in intro area that aren't necessary (you'll need to read the cookbook entry for more details anyways)
Also removing one example (now possible with using bcrypt from the beginning) and related tweaks.
Also filling in other details related to using BCrypt
| { | ||
| "require": { | ||
| "...": "all the other dependencies...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just ... to be consistent woth the other json examples
👍 @ircmaxell as you started this (and because you are the security expert), I would appreciate if you could have a look if this is heading in the good direction. |
| "...": "all the other dependencies...", | ||
| "ircmaxell/password-compat": "~1.0.3" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing newline
Changed sha1 into bcrypt continued...
This follows@wouterj's start in#3356. It uses BCrypt in even more places and reorganizes some sections. Hopefully this puts us in a good place. Comments warmly appreciated!
Thanks!