Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Book][Validation] Fix small typos#3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
iamdto wants to merge1 commit intosymfony:2.2fromiamdto:fix-validation
Closed

[Book][Validation] Fix small typos#3371

iamdto wants to merge1 commit intosymfony:2.2fromiamdto:fix-validation

Conversation

iamdto
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.2+
Fixed tickets-

This fixes syntax highlighting and remove a trailing whitespace on the validation book.

@xabbuh
Copy link
Member

Good catch. But unfortunately there's already a PR (see#3345).

@iamdto
Copy link
ContributorAuthor

Yeah you're right, I didn't see this one.

@xabbuh@wouterj@weaverryan: maybe PRs and issues titles should be prefixed by something like the first two levels of the hierarchy (i.e.[Cookbook][Assetic],[Book][Assetic] etc.) in order to avoid duplicate PRs?

For example the documentation for contributing to the core code state that:

To ease the core team work, always include the modified components in yourpull request message, like in:    [Yaml] fixed something    [Form] [Validator] [FrameworkBundle] added something

But there is no such thing for the documentation.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@iamdto@xabbuh@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp