Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Indicate that Group Sequence Providers can use YAML#3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
In the docs, it was unclear that you could use group sequence providers without using annotations. (It took me some trial and error to figure out how to do it.) I've indicated that it can also use YAML, and how to do so. I've never used XML for validation, so I don't feel qualified to add info about XML to the docs.
wouterj commentedDec 20, 2013
Good point! We need to rewrite it a bit, so the text is generic (it doesn't talk about any format in favor). Then we can change the example to a configuration block, which shows all possible formats. I'll take a look at the configuration for the other formats, if you could rewrite the text it would be awesome! (maybe some other docguy will help you with that) |
karptonite commentedDec 20, 2013
Most of that code example has to be in PHP, actually--the Group Sequence Provider itself is a method implemented by the Entity. A new configuration block just for indicating that there is a group sequence provider seems like overkill. Maybe it can be pulled into the configuration block above? |
weaverryan commentedJan 20, 2014
Hi guys! I've decided to merge this on now. We usually have different code blocks for the different formats I think that would be nice, so if someone wants to create a new PR with that, awesome. If not, having this erged in is already a nice improvement. Thanks! |
…tonite)This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes#3369).Discussion----------Indicate that Group Sequence Providers can use YAMLIn the docs, it was unclear that you could use group sequence providers without using annotations. (It took me some trial and error to figure out how to do it.) I've indicated that it can also use YAML, and how to do so. I've never used XML for validation, so I don't feel qualified to add info about XML to the docs.Commits-------7512b65 Indicate that Group Sequence Providers can use YAML
…SequenceProvider (xabbuh)This PR was merged into the 2.3 branch.Discussion----------[Book][Validation] configuration examples for the GroupSequenceProvider| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |This pull requests adds examples in different formats for the GroupSequenceProvider feature of the Validator component (it's the completion of#3369).Commits-------bfd2af4 [Book][Validation] configuration examples for the GroupSequenceProvider
In the docs, it was unclear that you could use group sequence providers without using annotations. (It took me some trial and error to figure out how to do it.) I've indicated that it can also use YAML, and how to do so. I've never used XML for validation, so I don't feel qualified to add info about XML to the docs.