Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Changed sha1 into bcrypt#3356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -1358,6 +1358,15 @@ the password is simply run through the ``sha1`` algorithm one time and without | |||
| any extra encoding. You can now calculate the hashed password either programmatically | |||
| (e.g. ``hash('sha1', 'ryanpass')``) or via some online tool like `functions-online.com`_ | |||
| .. caution:: | |||
| The above example is not meaned for practical usage, it uses a weak hash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I left the above example with sha1, because when using bcrypt it would be hard to get the hashed password.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is not meant
A larger change to the docs may be more suitable for the reader. For example we could move this section to be entirely on use of bcrypt and add an extra page elsewhere that describe pbkdf2 usage, and we can group "legacy hashing" algos like MD5, Rot13, Sha1, etc. |
You should add a note about the requirements somewhere. To use the BCrypt encoder, you need to upgrade to PHP 5.5 or install the "ircmaxell/password-compat" via Composer ... seeBCryptPasswordEncoder |
… details in intro area that aren't necessary (you'll need to read the cookbook entry for more details anyways)
Also removing one example (now possible with using bcrypt from the beginning) and related tweaks.
Also filling in other details related to using BCrypt
Thanks for starting with Wouter! I've continued the conversation with a new PR at#3405 with some additional changes. Thanks! |
We loose some information, but I don't think that information is necessary. I also made the change without testing it, so: Needs some review!
/cc@ircmaxell@weaverryan