Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Create compound.rst.inc #2362#3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dpcat237 commentedDec 14, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
Create description for "compound" option.
@dpcat237 the template goes in the description top part |
| **type**: ``boolean`` | ||
| This option define that if form is compound. It's independent of whether the form actually has children. A form can be compound and have no children at all, like for example an empty collection form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This option defines if form is compound.
maybe cut the line to 100 characters per line |
no, it must be wrapped after the first word that crosses the 72th character |
It doesn't make sense to only add this file. It is not included somewhere, you should include the option in the form types that makes sense. |
I'm sorry, it's one of my first pull request to this project and I didn't review pull request standards. I'll be more rigorous. |
And don't worry about the confusions. We really appreciate your contribution and are of course happy to help you finish your pull request. :) |
@wouterj do I have to add versionadded directive to this option too? |
@dpcat237 I don't think so, because it is there in all supported versions (it was added in 2.1) |
| **type**: ``boolean`` | ||
| This option define that if form is compound. It's independent of whether the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this should be a bit reworded:
This option specifies if a form is compound. This is independent of whether the form actually has children. A form can be compound but don't have any children at all (e.g. an empty collection form).
Sorry for the late suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1
Okay Ryan. Was pleasure help to community :) I'll try find time to be more involved in Symfony community ;) Regards |