Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Create data_class.rst.inc #2362#3334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dpcat237 commentedDec 14, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | #2362 |
Create data_class documentation.
| $builder->add('media', 'sonata_media_type', array( | ||
| 'data_class' => 'Acme\DemoBundle\Entity\Media', | ||
| )); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
remove this empty line
As I already said on your other PR, this option has to be included in some relevant form type docs |
@wouterj Do I have to do something else in this pull request? |
@dpcat237 we can also add this option to the base Form type, as it also exists there. |
| @@ -0,0 +1,11 @@ | |||
| data_class | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you should add a versionadded directive before this line:
..versionadded::2.4 The ``data_class`` option was introduced in Symfony 2.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But this isn't correct, right? Thedata_class option has always existed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, indeed. You're correcthttps://gist.github.com/WouterJ/5246728#file-tree-L100
Thanks Denys! I've patched this into the 2.3 branch at sha:00f4d31. Nice work with this and thanks for hanging out with us on the Hack Day :). Cheers! |
…bbuh)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#3415).Discussion----------[#3334] the data_class option was not introduced in 2.4| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |Commits-------c96e6eb [#3334] the data_class option was not introduced in 2.4