Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[WIP] Travis integration#3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👍 |
Maybe it's better to use symlinks than moving the bundle references around. |
Well, that'll be replaced by using sparse checkout, I just couldn't get it working yesterday. |
@wouterj I'm unable to open a PR to your fork. Can you pull this?tvlooy@b0e5412 That should work. FYI, I also tried with git-archive, which is able to download a directory from a repository but unfortunately GitHub doesn't allow git-archive requests. And I also tried with the SVN support which works too, but for some reason it downloads the directory for all tags and branches. So, you end up with a much much bigger download. Anyway, git sparse checkout work :-) |
Thank you@tvlooy! It all works perfect |
| SPHINXBUILD = sphinx-build | ||
| PAPER = | ||
| BUILDDIR = _build | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Themake.bat file? Isn't this one just for Windows? I use theMakefile locally. Also, what about only including the options we need - namelymake html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, the standard sphinx setup includes the make commands for unix and windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But we don't need both, do we? Don't we just need a small Makefile? I guess we should clarify - are we packaging enough to allow users to build or are we packaging only what we need to make Travis able to build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
while, this PR is created in the first place to solve#2722, which is about providing enough to make it work for a user. For travis, we don't need time (I think).
👍 I really like this idea - so let's get it done! Thanks Wouter! |
I've updated the docs for this new PR. It should be ready now! |
| ini INI | ||
| php-annotations Annotations | ||
| php-standalone Standalone Use | ||
| php-symfony Framework Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
added php-standalone and php-symfony, since they were introduced infabpot/sphinx-php#3
This PR was merged into the 2.3 branch.Discussion----------Created Documentation CHANGELOG| Q | A| --- | ---| Doc fix? | no| New docs? | yes| Applies to | 2.3+| Fixed tickets |#2579This is the second enhancement (after#3328) of the Symfony2 Documentation Process.This idea came from@shoomyth in#2579. Since@weaverryan is using gh to merge the Pull Requests, it's easy to scan through the commits and find the changes (I'm busy creating an automated script for this).The plan is to update the changelog each month, so people have a clear view on new articles or fixed things. It'll also be another attribution to the many symfony doc hero's!This PR lists the changes in the 2.3 branch for January. When we agree with this, it'll be update for changes in the 2.4 and master branches.My idea was to put a link to this article in the sidebar (ping@fabpot).We would love to get your opinion about this new change!Commits-------401737b Applied comments from@xabbuha6c68a9 Added CHANGELOG for 2.3
Signed-off-by: Rogerio Prado de Jesus <rogeriopradoj@gmail.com>
ping@weaverryan I know you're busy, but I really want to move on with this idea. |
This PR was merged into the 2.3 branch.Discussion----------[WIP] Travis integration| Q | A| --- | ---| Doc fix? | no| New docs? | no| Applies to | all| Fixed tickets |#2722,#3332##### Todo - [x] Using sparse checkout - [x] Update contributing docs - [ ] Squashing commits - [ ] Activate Travis hook (@fabpot)Commits-------37eb137 Update documentation8dec729 sparse checkoutsb6f693e Added CMFb1d9e62 Revert changes6cad008 Updated travis configc515613 Added .gitignore85b1b02 Try to supress bundle doc warningsf3cb8b1 Fixed submodules71a2ff4 Added needed config filesd312683 Added sphinx files
Merged at last! :) @fabpot or@javiereguiluz - could you activate the Travis hook in the repo settings and turn Thanks especially to Wouter for doing all the work on this. I'm sorry it took so long for me to merge it! |
Wow, thank you@weaverryan Now let's move to the other plans! :D |
@weaverryan@wouterj thanks for setting up Travis integration! I have asked@fabpot about enabling the webhook, so I guess it will be activated soon. |
Travis hook activated! |
Great, thank you@javiereguiluz and@fabpot ! |
This PR was merged into the 2.3 branch.Discussion----------Fix PSR coding standards error| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3| Fixed tickets |Commits-------da2ee60 Fix PSR coding standards error868de1e minor#3698 Dynamic form modification cookbook: Fix inclusion of code (michaelperrin)acf255d feature#3328 [WIP] Travis integration (WouterJ)5d99d88 [#3697] Backporting 2.3-specific changes1e8b0d4 Small fixes in code style8093719 Dynamic form modification cookbook: Fix inclusion of code37eb137 Update documentation8dec729 sparse checkoutsb6f693e Added CMFb1d9e62 Revert changes6cad008 Updated travis configc515613 Added .gitignore85b1b02 Try to supress bundle doc warningsf3cb8b1 Fixed submodules71a2ff4 Added needed config filesd312683 Added sphinx files
Todo