Refactor cookbook/console/logging#3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

tvlooy wants to merge1 commit intosymfony:masterfromtvlooy:2534

Closed

Refactor cookbook/console/logging#3322

tvlooy wants to merge1 commit intosymfony:masterfromtvlooy:2534

Conversation

Copy link

Contributor

tvlooy commentedDec 14, 2013

Q	A
Doc fix?	no
New docs?	yes
Applies to	2.3+
Fixed tickets	#2534

wouterj reviewed

Dec 14, 2013

View reviewed changes

cookbook/console/logging.rst

		@@ -71,183 +71,11 @@ Enabling automatic Exceptions logging
		-------------------------------------

		To get your console application to automatically log uncaught exceptions
		for all of your commands, you'll need to do a little bit more work.
		for all of your commands, you can use console events.

Copy link

Member

wouterjDec 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can add a link to /components/console/events here

Rewrite docs

6e7f16d

weaverryan added a commit that referenced this pull request

Dec 26, 2013

[#3322] Minor tweaks to facelift for console logging entry

2b65b23

Copy link

Member

weaverryan commentedDec 26, 2013

Very very nice job Tom! I've patched this into the 2.3 branch at sha:1e84cb0 with very minor tweaks at sha:2b65b23. This entry is much better now :).

Thanks!