Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

improve the serialization of custom user models#3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.3fromxabbuh:issue-3165
Dec 19, 2013

Conversation

xabbuh
Copy link
Member

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets#3165


When your ``User`` class implements the
:class:`Symfony\\Component\\Security\\Core\\User\\EquatableInterface`
interface, it is sufficient to just serialize the ``id`` property in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

When implementing EquatableInterface, you determine yourself which peoperties you use to compare the objects.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I changed the wording. What do you think?

@wouterj
Copy link
Member

+1 (btw, not to stop you contributing, but this weekend we have a sprint day, could you please leave some easy picks open for that day? 😺 )

@cordoval
Copy link
Contributor

@wouterj is all good, we are already on the hacking day 👶 where everything is possible

@xabbuh
Copy link
MemberAuthor

Oh, did I miss something? Thought that was more of a code hacking day.

@cordoval
Copy link
Contributor

you are good, is both

@wouterj
Copy link
Member

Xabbuh, yes you missed something. It's a hackday for many symfony related topics.

@cordoval I know it's not a big deal, but we don't have that many easy issues.

@xabbuh
Copy link
MemberAuthor

Sorry, that wasn't my intention. I will then focus on#954 and#958 if you are fine with that.

@cordoval
Copy link
Contributor

that means only one thing, we have to adapt, also we should closely work with the teams, that should help enforce things. Perfect! Is going as planned, as the goal will be achieved no matter what.

@wouterj
Copy link
Member

@xabbuh don't worry :) but yeah that's perfect, however I already started with the validator docs. (did not came that far)

weaverryan added a commit that referenced this pull requestDec 19, 2013
improve the serialization of custom user models
@weaverryanweaverryan merged commit962e204 intosymfony:2.3Dec 19, 2013
@weaverryan
Copy link
Member

Hey guys!

I also added a note related to AdvancedUserInterface at sha:7325ec5. Hopefully that helps - this is a complicated issue to describe and debug, unfortunately. And if you get the implementation right, it's not really important that you understand it.

Let me know if you have any further suggestions.

Thanks!

@xabbuhxabbuh deleted the issue-3165 branchDecember 19, 2013 09:32
weaverryan added a commit that referenced this pull requestDec 19, 2013
weaverryan added a commit that referenced this pull requestJan 2, 2014
weaverryan added a commit that referenced this pull requestJan 2, 2014
(cherry picked from commit38612bc)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@xabbuh@wouterj@cordoval@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp