Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Move curly bracket to be on the same line#3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.2fromifdattic:patch-1
Dec 19, 2013
Merged

Move curly bracket to be on the same line#3301

weaverryan merged 1 commit intosymfony:2.2fromifdattic:patch-1
Dec 19, 2013

Conversation

ifdattic
Copy link
Contributor

This makes PSR coding standard to pass and also gives more consistency between examples (as curly brackets are on the same line).

This makes PSR coding standard to pass and also gives more consistency between examples (as curly brackets are on the same line).
@wouterj
Copy link
Member

👍
(while it isn't a big deal, could you please add thePR template)

@ifdattic
Copy link
ContributorAuthor

Sure, I hope this is correct:

QA
Doc fix?yes
New docs?no
Applies to2.2
Fixed tickets

I should probably add another addition to docs I found...

Also a double colon (:) is missing in the link URL in your previous comment.

@wouterj
Copy link
Member

👍 (however, we just deprecated 2.2, so for the next PRs you should use at least 2.3)

@ifdattic
Copy link
ContributorAuthor

Thanks for letting me know.

But probably readme should be updated because now incontribution it says:... all pull requests must be based off of the 2.2 branch, not the master or 2.3 branch.

@wouterj
Copy link
Member

Indeed, that's wrong! I'll submit a PR soon.

weaverryan added a commit that referenced this pull requestDec 19, 2013
Move curly bracket to be on the same line
@weaverryanweaverryan merged commit8100b79 intosymfony:2.2Dec 19, 2013
@weaverryan
Copy link
Member

Nice fix Andrew! It's small, but we really like to get these things right :).

Cheers!

@ifdattic
Copy link
ContributorAuthor

Glad to help :)

Just finished reading the Symfony book so will be PR a couple more suggestions/typos/etc. that I think can improve a documentation. The Symfony book was a nice & useful read so it's great knowing you can add something to it.

@weaverryan
Copy link
Member

And we really appreciate these fixes - we don't get the opportunity very often to read the full chapters. So when people like you read them and have fixes, it's great!

See you on other PR's ;)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ifdattic@wouterj@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp