Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Move curly bracket to be on the same line#3301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This makes PSR coding standard to pass and also gives more consistency between examples (as curly brackets are on the same line).
👍 |
Sure, I hope this is correct:
I should probably add another addition to docs I found... Also a double colon ( |
👍 (however, we just deprecated 2.2, so for the next PRs you should use at least 2.3) |
Thanks for letting me know. But probably readme should be updated because now incontribution it says:... all pull requests must be based off of the 2.2 branch, not the master or 2.3 branch. |
Indeed, that's wrong! I'll submit a PR soon. |
Move curly bracket to be on the same line
Nice fix Andrew! It's small, but we really like to get these things right :). Cheers! |
Glad to help :) Just finished reading the Symfony book so will be PR a couple more suggestions/typos/etc. that I think can improve a documentation. The Symfony book was a nice & useful read so it's great knowing you can add something to it. |
And we really appreciate these fixes - we don't get the opportunity very often to read the full chapters. So when people like you read them and have fixes, it's great! See you on other PR's ;) |
This makes PSR coding standard to pass and also gives more consistency between examples (as curly brackets are on the same line).