Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Components][Console] Fix askConfirmation() description#3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 2 commits intosymfony:2.2frombicpi:fix_method_description
Dec 18, 2013
Merged

[Components][Console] Fix askConfirmation() description#3265

weaverryan merged 2 commits intosymfony:2.2frombicpi:fix_method_description
Dec 18, 2013

Conversation

bicpi
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets-

askConfirmation() only terminates on enteringy,n or nothing. API link added.

In this case, the user will be asked "Continue with this action?", and will
return ``true`` if the user answers with ``y`` or ``false`` if the user answers
with ``n``. The third argument to
:method:`Symfony\\Component\\Console\\Helper\\DialogHelper::askConfirmation`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no need to use the api link twice imo

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Where is the first usage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's no prior usage.

@wouterj
Copy link
Member

It also works for 'yes' and 'no' afaik

@bicpi
Copy link
ContributorAuthor

Seems that everything starting withy orn will be evaluated totrue orfalse respectively ($answer[0]).
Mh, I don't think this should be mentioned explicitly and it wasn't before.

Seehttps://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Console/Helper/DialogHelper.php#L219

weaverryan added a commit that referenced this pull requestDec 18, 2013
[Components][Console] Fix askConfirmation() description
@weaverryanweaverryan merged commitc753260 intosymfony:2.2Dec 18, 2013
@weaverryan
Copy link
Member

I like it, and agree that it's probably not really important that someone knows that yes/no and other combinations work. They want the user to be asked something, this explains that nicely.

Thanks everyone!

@bicpibicpi deleted the fix_method_description branchJanuary 5, 2014 13:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@bicpi@wouterj@weaverryan@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp