Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update routing.rst#3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Update routing.rst#3263
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -68,6 +68,13 @@ The route is simple: | ||
| return $collection; | ||
| .. note:: | ||
| When defining routes, the key (e.g. ``blog_show``) is meaningless. | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. it's not meaningless, you use it to reference to the route (for instance when generating a route in a template or controller) ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I concur. "Meaningless" is the wrong word. "Arbitrary" would be a better way of describing the route name. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I think we should move this to the last sentence of the next paragraph - so right after
I think if we do this (feel free to re-word), then we're in good shape! Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. We should at least avoid the first person perspective. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Thanks - updated my example above! Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @fatmuemoo What do you think about my proposed change above? Can you update your PR? If not, just let me know and someone else can open a new PR with the tweak. Cheers! ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Sounds good to me, thanks Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. @fatmuemoo :) - ok - but can you also update your pull request with the suggested changes? I can also update it for you if you'd like! Cheers! | ||
| Just be sure that it's unique so no other lines override it. In most cases, a | ||
| vendorname_shortbundlename_controllername_actionname pattern | ||
| (e.g. ``acme_blog_show``) is appropriate. | ||
| .. versionadded:: 2.2 | ||
| The ``path`` option is new in Symfony2.2, ``pattern`` is used in older | ||
| versions. | ||