Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update routing.rst#3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
fatmuemoo wants to merge1 commit intosymfony:masterfromfatmuemoo:patch-2
Closed
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletionsbook/routing.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,13 @@ The route is simple:

return $collection;

.. note::

When defining routes, the key (e.g. ``blog_show``) is meaningless.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it's not meaningless, you use it to reference to the route (for instance when generating a route in a template or controller)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I concur. "Meaningless" is the wrong word. "Arbitrary" would be a better way of describing the route name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should move this to the last sentence of the next paragraph - so right afterin your controller (keep reading). - how about:

Theblog_show is the internal name of the route, which just doesn't have any meaning yet and just needs to be unique. Later, you'll use it to generate URLs.

I think if we do this (feel free to re-word), then we're in good shape!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should at least avoid the first person perspective.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks - updated my example above!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fatmuemoo What do you think about my proposed change above? Can you update your PR? If not, just let me know and someone else can open a new PR with the tweak.

Cheers!

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds good to me, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fatmuemoo :) - ok - but can you also update your pull request with the suggested changes? I can also update it for you if you'd like!

Cheers!

Just be sure that it's unique so no other lines override it. In most cases, a
vendorname_shortbundlename_controllername_actionname pattern
(e.g. ``acme_blog_show``) is appropriate.

.. versionadded:: 2.2
The ``path`` option is new in Symfony2.2, ``pattern`` is used in older
versions.
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp