Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[WCM] Use KernelTestCase instead of WebTestCase for testing Command with a container#3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If it is not yet merged into 2.4, it won't apperently make it into 2.4 at all. Thus, addressing this for 2.5 and also adding a |
Conflicts:book/security.rstcomponents/property_access/introduction.rstcomponents/stopwatch.rstcookbook/templating/namespaced_paths.rstreference/twig_reference.rst
…ting Command with a container
Closing in favor of#3311 which now targets master. |
weaverryan added a commit that referenced this pull requestMar 5, 2014
…ode only requiring the Container (johnkary)This PR was merged into the master branch.Discussion----------Use KernelTestCase instead of WebTestCase for testing code only requiring the Container| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes (symfony/symfony#9739)| Applies to | 2.5| Fixed tickets | noneThis documents using the new KernelTestCase introduced insymfony/symfony#9739, which was recently merged to master for 2.5-dev.KernelTestCase was extracted from WebTestCase to become a more-focused base class for functional testing code that requires only a container but no client. WebTestCase is then more-focused to be used for tests requiring a client.If you think this needs any kind of version callout in the docs to highlight the base class change we can add that too.:rocket:Previous PR#3244 against the 2.4 branch was closed because the corresponding feature was not merged into 2.4.Commits-------6c52b92 [#3311] Use KernelTestCase instead of WebTestCase for tests needing only a Container
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents using the new KernelTestCase introduced insymfony/symfony#7704, which is pending acceptance and target version approval.
KernelTestCase was extracted from WebTestCase to become a more-focused base class for functional testing code that requires only a container but no client. WebTestCase is then more-focused to be used for tests requiring a client.
If you think this needs any kind of version callout in the docs to highlight the base class change we can add that too.
🚀