Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update validation.rst. Remove the print_r statement to match the expected output. (so the __toString method is called)#3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ByScripts wants to merge1 commit intosymfony:masterfromByScripts:patch-1

Conversation

ByScripts
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.3+
Fixed tickets

Remove the print_r statement to match the expected output. (so the __toString method is called)
@@ -129,7 +129,7 @@ simple example from inside a controller::
$errors = $validator->validate($author);

if (count($errors) > 0) {
return new Response(print_r($errors, true));
return new Response($errors);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will not work. The Response constructor expects a string or an object castable to string. ConstraintViolationList is not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hmm, sorry, actually it is. I never used the string casting on it though (and it is there only for debugging purpose anyway, so using print_r in the doc would at least make it clear it is not production-ready)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It has been tested by me and my workmate.

Using print_r returns a big output with a lot of noise. Nothing to do with
the expected results as describe in the doc.

When passing directly $errors, the output is exaclty the one described in
the doc. :)

Edit: Ok. Seen your second message :

I'm not against the usage of print_r, but in this case the description in
the doc should be accurate. Because it says the output should be
"Acme\BlogBundle\Author.name: This value should not be blank" but it's not
that at all. It's a big frightening bunch of data ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't know you could do this either :), but makes sense! For clarification, I just split it into multiple lines and added a note at sha:1a425cc. You don't get the nice-ness of relying on the automatic(string) casting inResponse, but this is pretty much just for debugging/playing, so I think clarity is more important.

@weaverryan
Copy link
Member

Hey Thierry!

Cool change, I've patched it into the 2.2 branch at sha:b535d86.

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ByScripts@weaverryan@stof

[8]ページ先頭

©2009-2025 Movatter.jp