Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fixed repeated verb in cookbook/serializer#3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

77web
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.3+
Fixed ticketsn/a

@@ -67,8 +67,8 @@ You can load normalizers and/or encoders by tagging them as
:ref:`serializer.encoder<reference-dic-tags-serializer-encoder>`. It's also
possible to set the priority of the tag in order to decide the matching order.

Here an example on how to load the load
the :class:`Symfony\\Component\\Serializer\\Normalizer\\GetSetMethodNormalizer`:
Here an example on how to load the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should behere follows orhere is presented

@77web
Copy link
ContributorAuthor

@cordoval
Thank you for review!
But, isn't "here is an example..." enough?
For me, "here follows" or "here is presented" seems too formal. Though I am not a native English speaker...

@cordoval
Copy link
Contributor

@77web as long as you add a missing verb i am fine 👶

@77web
Copy link
ContributorAuthor

@cordoval thank you again! I added "is" there.

@cordoval
Copy link
Contributor

perfect 👶

weaverryan added a commit that referenced this pull requestNov 28, 2013
…ializerfixed repeated verb in cookbook/serializer
@weaverryanweaverryan merged commit7a56692 intosymfony:2.3Nov 28, 2013
@weaverryan
Copy link
Member

Thanks for the fix Hiromi!

@77web77web deleted the fix_repeated_verb_in_cookbook-serializer branchNovember 28, 2013 23:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@77web@cordoval@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp