Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Fix PHP requirement in installation documentation#3198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Changed minimal PHP requirement from 5.3.8 to 5.3.3, as it's the version required in composer for symfony/symfony. If 5.3.8 (or higher) is the recommended one, I'll suggest to add a comment about it.
I'm against updating it to 5.3.3. Fromthe readme:
However, we can maybe rephrase this a bit to make it clear that you can also use it with 5.3.3 and then link to this section in the readme. Could you please do that? |
@wouterj Thanks for the input, that's what I thought too. Is it better now ? If yes, I'll apply it to the other translations as well (at least for French, and ask an Italian speaker for some help :)). I don't know the syntax enough to add a link on "highly recommended" to the exact section of the README. Could you help on that ? |
+1 for "5.3 with 5.8 warning". |
@gnutix I think it's better to put the link + caution in the I think the best way is to add a caution directive at the bottom of the 'Required' section on that page. It'll look like: ..caution:: Be aware that Symfony2 has some known limitations when using PHP 5.3.8 or below. For more information see the `Requirements section of the readme`_.. _`Requirements section of the readme`:https://github.com/symfony/symfony#requirements The last line should be put on the bottom of the file. |
@wouterj done. I'm hesitating if that "caution" block should be on the bottom on the requirements page or bottom of the requirements section. Think it's more visible on the section, as PHP is listed in there. WDYT? |
@gnutix the caution block should be in the section. The last line of my snippet is only telling sphinx to which url the text between backticks in the block should link. It is not displayed. This information should be placed at the bottom of the file. |
@wouterj Thanks for the tip! Fixed it. (I should really learn that syntax...) |
Thanks Ryan :) |
@weaverryan looks like only 2.2 branch was updated. What about master and 2.3? |
@garak 2.2 is merged into 2.3 on a regular basis (and 2.3 into master). So 2.3 will be updated on the next merge (Ryan generally does such a merge after merging a bunch of PRs) |
thanks for clarification stof! |
So, the final wording suggests that PHP 5.3.8is not good, while Symfony2 README states that itis. |
@garak Argh, nice catch ! Should be |
If you look at the bugs, you see a bug for 5.3.8, so that version is also not good |
@wouterjhttps://github.com/symfony/symfony/blob/master/README.md So it's buggy with |
A, "before"... I think I misread it, so yeah could you please open a PR to fix the caution? |
Changed minimal PHP requirement from 5.3.8 to 5.3.3, as it's the version required in composer for symfony/symfony. If 5.3.8 (or higher) is the recommended one, I'll suggest to add a comment about it.