I always use $ to indicate it's a jQuery object, but if it's confusing I agree with removing them

so 👍

(could you please include thePR template into your PR description?)

Actually the variable collectionHolder should be assigned within the jQuery ready function, but declared outside, since it is used in other functions as well.

Hi Giuseppe!

It's subjective, but I don't agree with removing the$ in front of the variables. I believe it's a semi-standard -http://stackoverflow.com/questions/205853/why-would-a-javascript-variable-start-with-a-dollar-sign#answer-553734. We'll see what others think. But you're right about the variable move :).

Cheers!

Using$ in front is also a best practice for me; at first glance you know what kind of variable it is.

In case we keep the$ prefix, we can add a notice explaining its meaning.

That sounds like a good suggestion to me.@attardi can you make the change to put the $ back and add a note about it?

Thanks!

I used to prefix my jQuery object with$ too.

On 11/9/2013 18:59, Ryan Weaver wrote:

That sounds like a good suggestion to me.@attardi
https://github.com/attardi can you make the change to put the $ back
and add a note about it?

Thanks!

I did it.
However github generated another branch when I tried to edit.
Then I closed and it yold me I had unmerged pull requests.
I am not sure I did the right thing.

-- Beppe

@attardi you should go to your repo, select the patch-1 branch and do the updates then.

On 11/9/2013 19:47, Wouter J wrote:

@attardihttps://github.com/attardi you should go to your repo,
select the patch-1 branch and do the updates then.

—
Reply to this email directly or view it on GitHub
#3157 (comment).

Did it.
I changed the name of collectionHolder to $collectionHolder, because
that too is a jQuery variable.

-- Beppe

Thanks everyone! Small tweak at sha:ae5a6d2

Cheers!