Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Removed 2.2 references as it reaches eom#3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -1873,7 +1873,7 @@ Learn more from the Cookbook | |||
| .. _`Symfony2 Form Component`: https://github.com/symfony/Form | |||
| .. _`DateTime`: http://php.net/manual/en/class.datetime.php | |||
| .. _`Twig Bridge`: https://github.com/symfony/symfony/tree/2.2/src/Symfony/Bridge/Twig | |||
| .. _`form_div_layout.html.twig`: https://github.com/symfony/symfony/blob/2.2/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig | |||
| .. _`Twig Bridge`: https://github.com/symfony/symfony/tree/master/src/Symfony/Bridge/Twig | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For what reason did you choose themaster branch and not, for example,2.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
so we don't have to change it every time a new version is released... and because there is no 2.4 branch currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah okay, didn't check that. But I'd suggest to wait for the release or
change the branch Name in advance. Otherwise, when 2.5 was released, you
would be linked to the 2.5 branch Ehen reading the 2.4 docs. That can be
rather confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We just basically don't have a good way to handle this yet - we talked a bit about it here:#2692 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh why not linking to the subtree repo, like for the Form component ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Linking to the subtree repo is nonetheless a good idea. But it doesn't really solve our versioning problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh the link to the Form subtree just links to the repo without specifying a branch. You are not changing the link here.
It would not solve it for the other 2 links targetting specific files though. These ones need versionning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@stof which for all Symfony repositories means that you browse through the master branch if you don't select another branch.
Merged - thanks! |
This PR is an addition to#3143