Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Update references to current branch#3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
E.g. changed "2.2" to "2.3" and so on
| @@ -13,7 +13,7 @@ Before contributing, you need to become familiar with the :doc:`markup | |||
| language <format>` used by the documentation. | |||
| The Symfony2 documentation is hosted on GitHub: | |||
| 2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this doesn't seem to be correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you just added a random 2, didn't you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right. I didn't find a way to amend a commit made on github. Maybe it's better to close this PR and make a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Forget it, just found a way and edited my commit. Thank you!
+1, 2.2 reached eom this month. Let's wait til the last 2.2 release is done and then merge this. Could you please also fix the README.md and CONTRIBUTING.md files? |
@wouterj you mean 2.2 reached EOM this month yes? |
@merk yes, indeed. Fixed now :) |
This and#3144 look ready to go, but I'm actually not sure exactly of Nov 2013 EOM means Nov 1st or Nov 30th :). I think there will be at least one more Symfony 2.2 release (since there are commits to that branch that aren't in a release yet), so I think we'll wait until towards the end of the month to official end maintenance on the 2.2 branch in the docs. Thoughts? |
👍 The EOM will be announced on the Symfony website, won't it? |
Usually, it's mentioned in the last release. I already said in#3144 that I agree with@weaverryan point here :) Symfony 2.4 is released at the end of this month, so I expect a 2.2.* release a week or so before that. |
Update references to current branch
Thanks! |
E.g. changed "2.2" to "2.3" and so on