Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Add note about PHP 5.3 behaviour and proxies.#3018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedSep 28, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all (or 2.1+) |
| Fixed tickets | symfony/symfony#9119 |
2.1 is deprecated too, this should get merged in 2.2 |
It doesn't matter, this is a clarification about the feature so it should be added to |
| Under PHP 5.3, you cannot proxy the session handler interface for native PHP handlers, | ||
| only user handlers so if you write proxies, be aware they will only work for user-land | ||
| session save handlers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd split this into two sentences (I also made some minor tweaks to the wording):
Until PHP 5.3, you cannot proxy the session handler interface for native PHP handlers, but only for custom handlers. Thus, if you write proxies, be aware that they will only workfor user-land session save handlers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's wrong. If you say "since 5.3" it means since 5.3.0 up to the current version (5.5.x). That is not the case. "Under PHP 5.3" means all version of PHP 5.3.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're correct. I meantuntil (I changed my suggestion). MaybeBefore PHP 5.4 was even better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Until is still not accurate. Before PHP 5.4 or Under PHP 5.3 are the only two that convey the accuracy of what needs to be said.Before PHP 5.4 is best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm fine withBefore PHP 5.4, but I dont understand why until is not correct.Under PHP 5.3 is giving me the feeling, that it was not possible in all PHP versions before PHP 5.3 and that is has been introduced in PHP 5.3.
Add note about PHP 5.3 behaviour and proxies.