👎 imo having the else makes the code easier to understand and read

ok you advocate bad practices?

no, I give my opinion based on my preferences.

granted, but i still think is simpler to read this way, cleaner and less lines, and advocate a good practice

When talking about cleaner ways, I'd prefer just onereturn statement like this:

if (...) {$response =...;}else {$response =...;}return$response;

The Symfony codebase is using early returns withoutelse. So this PR is making it consistent with the code

ok, 👍 then :)

Thanks for the clarification,@stof. Is it documented anywhere? I didn't find it in the CS and the first example inhttp://symfony.com/doc/current/contributing/code/standards.html doesn't follow this way.

I don't think it is written in the doc, but it is applied when reviewing code (it may be worth adding it in the doc)

At least we should change the example to be consistent which what is actually the "standard" being used.

if ('string' ===$dummy) {if ('values' ===$mergedOptions['some_default']) {returnsubstr($dummy,0,5);    }returnucwords($dummy);}else {thrownew \RuntimeException(sprintf('Unrecognized dummy option "%s"',$dummy));}

This would match the standard?

Or should we use the same style to throw exceptions? Like this:

if ('string' ===$dummy) {if ('values' ===$mergedOptions['some_default']) {returnsubstr($dummy,0,5);    }returnucwords($dummy);}thrownew \RuntimeException(sprintf('Unrecognized dummy option "%s"',$dummy));

👍 ready to merge then 🔨

i guess this is not that important, closing@weaverryan

I is important, code in the doc should follow symfony standards.

yes but this is a change, don't want to change the whole documentation examples, so it should be a simple merge right?

Yes, it's a simple merge

Hey Luis!

I've patched this into the 2.2 branch at sha:e4ecb50. Thanks for this change and for the good conversation around this - the coding standards will be clearer after#2886.

Thanks!