Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DIC] Added note on untrimmed parameters (XML)#2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
gnugat wants to merge1 commit intosymfony:masterfromgnugat:dic-xml-parameters
Closed

[DIC] Added note on untrimmed parameters (XML)#2876

gnugat wants to merge1 commit intosymfony:masterfromgnugat:dic-xml-parameters

Conversation

@gnugat
Copy link

In XML configuration, the value betweenparameter tags isn't trimmed,
which can lead to unexpected behavior.

Seesymfony/symfony#8661

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i prefer a caution directive

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done :) .

@wouterj
Copy link
Member

Whoa, that's quick! 🚀

👍

@wouterj
Copy link
Member

This should be placed somewhere below, where we talk about constants as parameters

@stof
Copy link
Member

stof commentedAug 7, 2013

@wouterj It is true for all parameters, not only for constants (it can hurt you for class names too for instance)

@gnugat
Copy link
Author

@wouterj like@stof said it is true for every type of parameters. But maybe I hould change the example to make it clearer?

Perhaps I should add a classname parameter?

@wouterj
Copy link
Member

Well, make it indeed easier to understand. What about taking the mailer example? Settingmailer.transport tophpmail.

And after that, can you please squash your commits (if you know how to do that)?

@gnugat
Copy link
Author

Done, I added the exact value of the retrieved parameter, so we can see the line returns and spaces, and I also added a note on constants and class names which can throw exceptions.
The commits have been squashed into one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you must use double backticks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done, and squashed :)

In XML configuration, the value between` parameter` tags isn't trimmed,which can lead to unexpected behavior.Seesymfony/symfony#8661
@weaverryan
Copy link
Member

👍 great note Loïc (and a clean PR)! I've patched this into the 2.2 branch at sha:1b707dd

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnugat@wouterj@stof@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp