Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[WCM] [The Book, Translations] added doc for translation domain cascading#2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Some information about translation domain cascading.
wouterj commentedJul 14, 2013
The translation docs got a big rewrite in#2545 This needs a rebase when that is merged |
wouterj commentedJul 14, 2013
And could you please add a versionadded:: 2.4 directive before the new text? |
book/translation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
:: instead of :
This PR was merged into the 2.2 branch.Discussion----------[Security] fixed issue where x509 authentication clears unrelated tokens| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#8226| License | MIT| Doc PR |symfony/symfony-docs#2825| Notes | Replaces PR#8283TODO:- [x] Feedback on change to make sure security is not affected- [x] Fix other authentication listeners (they suffer the same problem)- [x] Write unit tests for bug and maybe a few listener classes as wellThis pull request is the summary of the problem mentioned in the ticket above.It only fixes the "disappearing token" problem for one authentication provider, not all. If acceptable, the change needs to be applied to all authentication listeners since they always clear all tokens from the security context.Commits-------2317443 [Security] fixed issue where authentication listeners clear unrelated tokens
xabbuh commentedJul 22, 2013
Now, the versionadded directive after the text should be removed. |
weaverryan commentedOct 2, 2013
It looks like there was some confusion with numbering (this got linked to Symfony's 8528 issue, even though it is unrelated), but the original code PRsymfony/symfony#8489 was closed without being merged. Thanks! |
Documentation for an unmerged PR which adds the possibility to use an array of translation domains instead of a single one, thus providing a fallback mechanism.